Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename diff args new #268

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Rename diff args new #268

merged 7 commits into from
Nov 9, 2023

Conversation

adisos
Copy link
Collaborator

@adisos adisos commented Nov 9, 2023 •
edited
Loading

Issue #267

@adisos adisos linked an issue Nov 9, 2023 that may be closed by this pull request
Rename diff analyzer args #267
Closed
@adisos adisos requested a review from zivnevo November 9, 2023 08:03
zivnevo
zivnevo requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@zivnevo zivnevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tiny things

pkg/netpol/diff/connectivity_diff.go Outdated Show resolved Hide resolved
pkg/netpol/diff/diff_formatter_dot.go Outdated Show resolved Hide resolved
pkg/netpol/diff/diff_formatter_text.go Outdated Show resolved Hide resolved
@adisos adisos merged commit 2392bbc into main Nov 9, 2023
4 checks passed
@adisos adisos deleted the rename_diff_args_new branch November 9, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivnevo zivnevo zivnevo approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename diff analyzer args
2 participants
@adisos @zivnevo