Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 424 : textual output small fix #426

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

shireenf-ibm
Copy link
Contributor

@shireenf-ibm shireenf-ibm commented Oct 23, 2024

#424

  • adding new line to textual outputs that did not have (connlist + diff);
  • tests of list with exposure-analysis (with non empty result) had new line at the end
  • added new line to case of empty exposure analysis section (test run with --exposure but there is no exposure)

…); tests of list with exposure-analysis had new line at the end
@shireenf-ibm shireenf-ibm requested a review from adisos October 23, 2024 09:16
Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added few comments.
please also check md,csv output

pkg/netpol/connlist/conns_formatter_txt.go Outdated Show resolved Hide resolved
pkg/netpol/connlist/conns_formatter_txt.go Outdated Show resolved Hide resolved
@shireenf-ibm
Copy link
Contributor Author

added few comments. please also check md,csv output

csv is good
added new line at the end of md with connlist output (with exposure there is a new line at the eof)

@shireenf-ibm shireenf-ibm requested a review from adisos October 28, 2024 14:29
@adisos adisos linked an issue Nov 4, 2024 that may be closed by this pull request
@shireenf-ibm shireenf-ibm merged commit 8cfc3d2 into main Nov 4, 2024
4 checks passed
@shireenf-ibm shireenf-ibm deleted the issue_424_textual_output_small_fix branch November 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

textual output small fix
2 participants