explainability #459

tanyaveksler · 2024-12-10T07:52:56Z

After cleaning - this branch contains only changes related to explainability (relatively to main)

…ons (to preserve explainability data from both directions). Updating testing data accordingly.

adisos · 2024-12-16T05:56:26Z

hi @tanyaveksler, note there are more conflicts from main to resolve now (after another PR merge).
Where are the review comments we wrote last week?

pkg/netpol/eval/internal/k8s/policy_connections.go

pkg/netpol/eval/check.go

Added no connection explanation for non-matching named ports case Added more explanation tests

More refined explanation of protocols/ports denied by NPs

Sorting the order of NPs in explainability output

… a protocol

…ering also rules layer) Added new explaination test.

More delicate updating implying rules.

tanyaveksler · 2025-01-14T14:46:15Z

Add example with multiple NPs that allow the same connection.

simplified complement pass connections calculation.

…e in anp_banp_blog_demo)

test_outputs/connlist/anp_and_banp_using_networks_and_nodes_test_explain_output.txt

test_outputs/connlist/anp_banp_blog_demo_2_explain_output.txt

Signed-off-by: adisos <[email protected]>

shireenf-ibm · 2025-02-13T11:45:24Z

if explain flag is used with unsupported format, should add log warning that it is supported only with text output format

done

Signed-off-by: adisos <[email protected]>

…ning with --explain

…-analyzer into explainability_new_clean

* list with both explain and exposure * merge + output fixes * new example - no need to turn off explain for exposure optimizations * merge + update outputs

pkg/netpol/eval/resources.go

Signed-off-by: adisos <[email protected]>

pkg/netpol/connlist/connlist.go

test_outputs/connlist/anp_and_banp_using_networks_and_nodes_test_explain_output.txt

test_outputs/connlist/anp_banp_blog_demo_explain_output.txt

explainability

4684411

pull-request-size bot added the size/XXL label Dec 10, 2024

tanyaveksler requested a review from adisos December 10, 2024 07:59

More delicate handling of intersection of ingress and egress connecti…

8217a4b

…ons (to preserve explainability data from both directions). Updating testing data accordingly.

make linter happy

1e7cbb9

tanyaveksler commented Dec 23, 2024

View reviewed changes

pkg/netpol/eval/internal/k8s/policy_connections.go Outdated Show resolved Hide resolved

pkg/netpol/eval/internal/k8s/policy_connections.go Show resolved Hide resolved

pkg/netpol/eval/check.go Outdated Show resolved Hide resolved

tanyaveksler added 17 commits December 23, 2024 11:57

Merge branch 'main' into explainability_new_clean

faa7ad7

fixing lint errors

181b9ac

Merge branch 'main' into explainability_new_clean

67ef886

More delicate handlinng of IPblock default connections explanation;

d50485b

Added no connection explanation for non-matching named ports case Added more explanation tests

More compact explainability print

cd17f64

Fixed lint error

326a88e

Merge branch 'main' into explainability_new_clean

4395e77

More compact explanation printing.

929c75d

Added more explainability tests.

ffe247c

More refined explanation of protocols/ports denied by NPs

Added more explainability tests.

520ef12

Sorting the order of NPs in explainability output

Merge branch 'main' into explainability_new_clean

9c947f6

Added a comment

409629a

Sorting together explanations for specific ports and for all ports in…

48ceb56

… a protocol

Added more tests

4686e3e

Added more delicate collect/override implying rules mechanism (consid…

710077a

…ering also rules layer) Added new explaination test.

Make linter happy

49050df

Changed explanation output for empty Xgress rules;

d78e3c4

More delicate updating implying rules.

tanyaveksler added 5 commits January 14, 2025 17:02

make linter happy;

4ab3d96

simplified complement pass connections calculation.

make linter happy

2f52f7b

Merge branch 'main' into explainability_new_clean

76c3876

changed names of pods in anp_banp_blog_demo test

ae74452

Changed named of pods in anp_banp_blog_demo_2 (according to the chang…

3385cb1

…e in anp_banp_blog_demo)

shireenf-ibm and others added 2 commits February 13, 2025 10:07

tiny change in output

9b4437b

Merge branch 'main' into explainability_new_clean

f796234

adisos reviewed Feb 13, 2025

View reviewed changes

test_outputs/connlist/anp_and_banp_using_networks_and_nodes_test_explain_output.txt Outdated Show resolved Hide resolved

shireenf-ibm added 2 commits February 13, 2025 10:23

lint fix

f83ed64

changing LIST to list

707a73b

adisos reviewed Feb 13, 2025

View reviewed changes

test_outputs/connlist/anp_banp_blog_demo_2_explain_output.txt Outdated Show resolved Hide resolved

test_outputs/connlist/anp_banp_blog_demo_2_explain_output.txt Outdated Show resolved Hide resolved

adisos and others added 4 commits February 13, 2025 12:10

update explain_analysis.md

68cdf79

Signed-off-by: adisos <[email protected]>

changes in outputs + update explain_analysis.md

cc5f954

running make test-update removes empty lines on top of files

fbb5f6b

adding warning when running --explain with unsupported format

e652c38

shireenf-ibm and others added 6 commits February 13, 2025 14:07

ignore explain value for not supported formats

b30d395

fix lint errors

a32750d

update example test

ff2df49

Signed-off-by: adisos <[email protected]>

fix: remove connlist No conns lines from unsupported formats when run…

8f15cd3

…ning with --explain

Merge branch 'explainability_new_clean' of github.com:np-guard/netpol…

bb60efa

…-analyzer into explainability_new_clean

list support explain flag with exposure flag (#503)

49808ad

* list with both explain and exposure * merge + output fixes * new example - no need to turn off explain for exposure optimizations * merge + update outputs

adisos reviewed Feb 13, 2025

View reviewed changes

pkg/netpol/eval/resources.go Outdated Show resolved Hide resolved

adisos and others added 3 commits February 13, 2025 15:20

remove unused OnlyCommonRules() and unexport OnlyDefaultRule()

81aa3b2

Signed-off-by: adisos <[email protected]>

unexport Explanation field in singleConnFields

6a9a9c2

Signed-off-by: adisos <[email protected]>

revert changes to a deprecated func

f196e42

adisos reviewed Feb 13, 2025

View reviewed changes

pkg/netpol/connlist/connlist.go Outdated Show resolved Hide resolved

adisos reviewed Feb 16, 2025

View reviewed changes

test_outputs/connlist/anp_and_banp_using_networks_and_nodes_test_explain_output.txt Outdated Show resolved Hide resolved

test_outputs/connlist/anp_banp_blog_demo_explain_output.txt Outdated Show resolved Hide resolved

adisos mentioned this pull request Feb 16, 2025

[conn-list] list explanation support #460

Closed

3 tasks

replace "list" with "connections" - explain output

bbef37f

adisos linked an issue Feb 16, 2025 that may be closed by this pull request

[conn-list] list explanation support #460

Closed

3 tasks

updating explain output - np rules explain

ec654e0

adisos approved these changes Feb 16, 2025

View reviewed changes

adisos merged commit e1d7896 into main Feb 16, 2025
4 checks passed

adisos deleted the explainability_new_clean branch February 16, 2025 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

explainability #459

explainability #459

tanyaveksler commented Dec 10, 2024

adisos commented Dec 16, 2024

tanyaveksler commented Jan 14, 2025

shireenf-ibm commented Feb 13, 2025

explainability #459

explainability #459

Conversation

tanyaveksler commented Dec 10, 2024

adisos commented Dec 16, 2024

tanyaveksler commented Jan 14, 2025

shireenf-ibm commented Feb 13, 2025