Skip to content

Commit

Permalink
Update pkg/vpcmodel/semanticDiffSubnets.go
Browse files Browse the repository at this point in the history
Co-authored-by: Adi Sosnovich <[email protected]>
  • Loading branch information
ShiriMoran and adisos authored Nov 9, 2023
1 parent 6c4d71a commit 025228f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/vpcmodel/semanticDiffSubnets.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,7 @@ func (subnetConfConnectivity *SubnetConfigConnectivity) subtract(other *SubnetCo
if otherSrc, ok := other.subnetConnectivity[srcInOther]; ok {
if otherConn, ok := otherSrc[dstInOther]; ok {
// ToDo: https://github.com/np-guard/vpc-network-config-analyzer/issues/199
subtractConn := conns.Subtract(otherConn)
if subtractConn.IsEmpty() {
if conns.Equals(otherConn) {

Check failure on line 134 in pkg/vpcmodel/semanticDiffSubnets.go

View workflow job for this annotation

GitHub Actions / build-and-test

conns.Equals undefined (type *common.ConnectionSet has no field or method Equals)
continue // no diff
}
connDiff.conn2 = otherConn
Expand Down

0 comments on commit 025228f

Please sign in to comment.