Skip to content

Commit

Permalink
added test, there seems to be an issue in func (conn *ConnectionSet) …
Browse files Browse the repository at this point in the history
…ContainedIn(other *ConnectionSet)
  • Loading branch information
ShiriMoran committed Jan 4, 2024
1 parent 1f80d4a commit 0f00f59
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/ibmvpc/explainability_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ func TestQueryConnectionSG2(t *testing.T) {
require.Fail(t, "vpcConfig equals nil")
}
// test 1: only a subset of the rules are relevant
// todo not working
// todo not working, seems to be due to bug in func (conn *ConnectionSet) ContainedIn(other *ConnectionSet)
connectionUDP1 := common.NewConnectionSet(false)
connectionUDP1.AddTCPorUDPConn(common.ProtocolUDP, common.MinPort, common.MaxPort, common.MinPort, common.MaxPort)
explanbilityStr1, err1 := vpcConfig.ExplainConnectivity("vsi2-ky[10.240.20.4]", "vsi3b-ky[10.240.30.4]", connectionUDP1)
Expand All @@ -333,5 +333,6 @@ func TestQueryConnectionSG2(t *testing.T) {
fmt.Println(explanbilityStr1)
fmt.Println("---------------------------------------------------------------------------------------------------------------------------")

// test3: the required connection contains the existing one per connection (so answer should be no) but neither is all connections
// test2: the required connection contains the existing one per connection (so answer should be no) but neither is all connections
// todo: after the above bug is fixed this test will be added
}

0 comments on commit 0f00f59

Please sign in to comment.