make lint happy

pkg/vpcmodel/grouping.go

@@ -169,17 +169,13 @@ func (g *GroupConnLines) groupExternalAddressesForSubnets() {
 				continue
 			}
 			connString := conns.EnhancedString()
-			hasExternal := false
 			switch dst.(type) {
 			case Node:
-				if dst.(Node).IsPublicInternet() {
-					hasExternal = true
-					g.srcToDst.addPublicConnectivity(src, connString, dst.(Node))
-				}
-			}
+				// connection is to the internet; this and connection between subnets are the only types being analyzed here
+				g.srcToDst.addPublicConnectivity(src, connString, dst.(Node))
 			// since pgw enable only egress src can not be public internet
 			// not an external connection in source or destination - nothing to group, just append
-			if !hasExternal {
+			default:
 				res = append(res, &GroupedConnLine{src, dst, connString})
 			}
 		}

pkg/vpcmodel/subnetsConnectivity.go

@@ -1,9 +1,10 @@
 package vpcmodel
 
 import (
+	"github.com/np-guard/vpc-network-config-analyzer/pkg/common"
+
 	"errors"
 	"fmt"
-	"github.com/np-guard/vpc-network-config-analyzer/pkg/common"
 )
 
 // VPCsubnetConnectivity captures allowed connectivity for subnets, considering nacl and pgw resources