Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance functionality related to pgws and fips to be oblivious to specific cidr #332

Closed
ShiriMoran opened this issue Jan 18, 2024 · 2 comments
Assignees
Labels

Comments

@ShiriMoran
Copy link
Contributor

ShiriMoran commented Jan 18, 2024

A pgws/fips are network interface dependent, and are oblivious to the exact cidr of an external address.
Certain functionality, as AllowedConnectivity(src, dst Node) *common.ConnectionSet of RoutingResource requires two Nodes, which specifies specific cidr.
The relevant functionality needs to be enhanced to be oblivious to the exact cidr and be dependent only in the specific network interface and the same for all external addresses.

(see #320 (comment))

@adisos
Copy link
Collaborator

adisos commented Feb 12, 2024

will be resolved by PR #372

Required update for explainability computation - avoid calling getContainingConfigNode for the input nodes of getRoutingResource

@adisos
Copy link
Collaborator

adisos commented Feb 13, 2024

opened small PR to update explainability code: #383

@adisos adisos closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants