Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

313 explain add routing resources #320

Merged
merged 108 commits into from
Jan 19, 2024
Merged

Conversation

ShiriMoran
Copy link
Contributor

No description provided.

haim-kermany
haim-kermany previously approved these changes Jan 17, 2024
Copy link
Contributor

@haim-kermany haim-kermany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not such an expert in go.
can you please make sure that the line:
actual := *potential
is actually creating a new copy?

pkg/vpcmodel/commonConnectivity.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
pkg/vpcmodel/grouping.go Outdated Show resolved Hide resolved
pkg/vpcmodel/grouping.go Outdated Show resolved Hide resolved
pkg/vpcmodel/grouping.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
@ShiriMoran ShiriMoran merged commit b135bd0 into main Jan 19, 2024
4 checks passed
@ShiriMoran ShiriMoran deleted the 313_explain_add_routingResources branch January 19, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RoutingResources to explainability
3 participants