Code

98 grouping with self loops#152

Code

Merged

ShiriMoran merged 55 commits intomainnp-guard/vpc-network-config-analyzer:mainfrom 98_grouping_with_self_loopsnp-guard/vpc-network-config-analyzer:98_grouping_with_self_loopsCopy head branch name to clipboardSep 28, 2023

+555-21

Commits

Commits on Aug 14, 2023

• So that grouping can be reused by subnetConnectivity

  ShiriMoran

  committed
  ee600cf

• VPCsubnetConnectivity computed and stored on EndpointElem instead of string so that (among others) grouping can be reused

  ShiriMoran

  committed
  43e8d41

Commits on Aug 17, 2023

• Merge remote-tracking branch 'origin/main'

  Show description for c3f5519
  ShiriMoran

  committed
  c3f5519

Commits on Aug 22, 2023

• Merge remote-tracking branch 'origin/main'

  ShiriMoran

  committed
  2eb1ef1

• fix comment (should have been part of a previous branch)

  ShiriMoran

  committed
  df04274

• extracting code to a function to be reused

  ShiriMoran

  committed
  e202533

• grouping with self loops - the first stages

  ShiriMoran

  committed
  b9f3d3f

Commits on Aug 23, 2023

• commit before context switching to #144

  ShiriMoran

  committed
  b97263d

Commits on Aug 24, 2023

• Merge remote-tracking branch 'origin/main' into 138_grouping_with_self_loops

  ShiriMoran

  committed
  abb8c03

• code for computing delta between GroupedConnLine

  ShiriMoran

  committed
  fe16a2d

Commits on Aug 27, 2023

• mergeGroups computed

  ShiriMoran

  committed
  7df7c1d

Commits on Sep 5, 2023

• merge groups to be merged

  ShiriMoran

  committed
  237f70b

• vsis should be grouped only if from the same subnet

  ShiriMoran

  committed
  82d7c34

• update testing

  ShiriMoran

  committed
  af7e0ab

• fixed comment

  ShiriMoran

  committed
  6897003

• lint comments #1

  ShiriMoran

  committed
  24e903e

• lint comments #2

  ShiriMoran

  committed
  2deebf5

• lint comments #3

  ShiriMoran

  committed
  be56d4d

• lint comments #4

  ShiriMoran

  committed
  d359811

Commits on Sep 12, 2023

• moved grouping self loops related code into a separate file

  ShiriMoran

  committed
  a35a6fc

• optimization: consider only groups which are of internal source and destination

  ShiriMoran

  committed
  0345421

Commits on Sep 13, 2023

• returning deleted by mistake

  ShiriMoran

  committed
  1ebd67a

• compute buckets

  ShiriMoran

  committed
  afe2247

• heuristic code written

  ShiriMoran

  committed
  e36112e

• groupsToBeMerge uses heuristic

  ShiriMoran

  committed
  1212e6f

Commits on Sep 14, 2023

• renaming

  ShiriMoran

  committed
  5db16fd

• bug fix

  ShiriMoran

  committed
  6cb4900

• redundant function

  ShiriMoran

  committed
  946ecc4

• improved alg description

  ShiriMoran

  committed
  1276933

• unit tests for grouping; the last one fails. Big must be fixed

  ShiriMoran

  committed
  878382f

Commits on Sep 18, 2023

• bug (typo) fix

  ShiriMoran

  committed
  a8a06b1

• finalizing test5

  ShiriMoran

  committed
  f65a63a

• Merge branch 'main' into 98_grouping_with_self_loops

  ShiriMoran

  authored
  744ac97

• adding another unit test

  ShiriMoran

  committed
  1388ee2

Commits on Sep 20, 2023

• Merge branch 'main' into 98_grouping_with_self_loops

  ShiriMoran

  authored
  0deeb4e

• initial review comments

  ShiriMoran

  committed
  3ad19b4

• Merge remote-tracking branch 'origin/98_grouping_with_self_loops' into 98_grouping_with_self_loops

  ShiriMoran

  committed
  d9f7a0c

• Merge remote-tracking branch 'origin/main' into 98_grouping_with_self_loops

  ShiriMoran

  committed
  ad43844

• Merge remote-tracking branch 'origin/main' into 98_grouping_with_self_loops

  ShiriMoran

  committed
  3e5898d

• not sure why this newline was missing; this line has to be excluded from the tests comparison

  ShiriMoran

  committed
  79ee4cd

Commits on Sep 21, 2023

• Merge branch 'main' into 98_grouping_with_self_loops

  ShiriMoran

  authored
  6e49140

• Update pkg/vpcmodel/groupingSelfLoop.go

  Show description for bfd3576
  

  ShiriMoran

  and

  adisos

  authored
  bfd3576

• Update pkg/vpcmodel/groupingSelfLoop.go

  Show description for 55b710e
  

  ShiriMoran

  and

  adisos

  authored
  55b710e

• CR comments

  ShiriMoran

  committed
  c89f318

• Merge remote-tracking branch 'origin/98_grouping_with_self_loops' into 98_grouping_with_self_loops

  ShiriMoran

  committed
  af436ba

Commits on Sep 27, 2023

• merge with main

  ShiriMoran

  committed
  b9b5d97

• Update pkg/vpcmodel/groupingSelfLoop.go

  Show description for 767cb52
  

  ShiriMoran

  and

  adisos

  authored
  767cb52

• Update pkg/vpcmodel/groupingSelfLoop.go

  Show description for de4b205
  

  ShiriMoran

  and

  adisos

  authored
  de4b205

• Update pkg/vpcmodel/groupingSelfLoop.go

  Show description for 5d0adca
  

  ShiriMoran

  and

  adisos

  authored
  5d0adca

• simple CRs comment

  ShiriMoran

  committed
  dd59da6

• Merge remote-tracking branch 'origin/98_grouping_with_self_loops' into 98_grouping_with_self_loops

  ShiriMoran

  committed
  048b44e

• Merge branch 'main' into 98_grouping_with_self_loops

  ShiriMoran

  authored
  353fa80

• CR fix - merge groups of VSI must have the same subnet in src and dst

  ShiriMoran

  committed
  0fbd72a

• CR fix - keep unified key

  ShiriMoran

  committed
  dc8e171

• CR: add documentation for each function

  ShiriMoran

  committed
  8e5a013