Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create drawio in ibmvpc #165

Merged
merged 26 commits into from
Sep 27, 2023
Merged

Create drawio in ibmvpc #165

merged 26 commits into from
Sep 27, 2023

Conversation

haim-kermany
Copy link
Contributor

  1. GenerateDrawioTreeNode() for exery resource
  2. DrawioGenerator - a new struct in vpcmodel pkg. that generate the treenodes
  3. rewrite DrawioOutputFormatter - now it is much simpler

please notice that DrawioOutputFormatter will be changed according to the grouping information

@haim-kermany haim-kermany requested a review from adisos September 19, 2023 08:37
adisos
adisos reviewed Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
Added a few comments

pkg/vpcmodel/abstractVPC.go Show resolved Hide resolved
pkg/ibmvpc/ibmDrawioGenerator.go Outdated Show resolved Hide resolved
pkg/ibmvpc/ibmDrawioGenerator.go Show resolved Hide resolved
pkg/vpcmodel/drawioGenerator.go Show resolved Hide resolved
@haim-kermany haim-kermany merged commit 27c4955 into main Sep 27, 2023
@haim-kermany haim-kermany deleted the create_drawio_in_ibmvpc branch September 27, 2023 08:34
@adisos adisos mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisos adisos adisos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haim-kermany @adisos