Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vpe #200

Merged
merged 140 commits into from
Oct 23, 2023
Merged

Support vpe #200

merged 140 commits into from
Oct 23, 2023

Conversation

haim-kermany
Copy link
Contributor

added support for vpe
basically, copying the behavior of ni-vsi
Adi, please review the vpcmodel / ibmvpc code
Ziv, please review the rest

pkg/drawio/createMapFile.go Outdated Show resolved Hide resolved
pkg/drawio/treeNodeInterface.go Outdated Show resolved Hide resolved
pkg/ibmvpc/ibmDrawioGenerator.go Outdated Show resolved Hide resolved
pkg/ibmvpc/ibmDrawioGenerator.go Outdated Show resolved Hide resolved
pkg/drawio/iconTreeNode.go Show resolved Hide resolved
pkg/drawio/layout.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@haim-kermany haim-kermany merged commit 0cb0e60 into main Oct 23, 2023
4 checks passed
@haim-kermany haim-kermany deleted the support-vpe branch October 23, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants