166 single group element #208
Conversation
…t testing for semantic diff connectivity
…uld return the diff
# Conflicts: # pkg/common/connectionset.go # pkg/vpcmodel/diffSubnets_test.go # pkg/vpcmodel/semanticDiffSubnets.go
…. each group has exactly one reference
pkg/vpcmodel/grouping.go
Outdated
| res, groupingSrcOrDst := g.groupLinesByKey(srcGrouping, groupVsi) | ||
| res = g.unifiedGroupedConnLines(res) |
There was a problem hiding this comment.
How is res affected by extendGroupingSelfLoops? It seems that only groupLinesByKey adds lines to res, so why on this stage the func unifiedGroupedConnLines works on res?
There was a problem hiding this comment.
@adisos good catch. So there are 2 questions to answer here: yours, and why still the fix that seems misplaced solved the issue, as per my testing and Haim's.
The original problem here is that extendGroupingSelfLoops "mess up with" the basic result of the grouping, modifying both sides and not only the targeted one. This is why we had a problem in the first place.
The fix I've put in indeed does not cover the problem, as you say. The reason it did seem to cover the problem is that is fixed the result res of the previous stage and for the case inline it was suffice. Clearly this is not a proper solution. I'll fix.
There was a problem hiding this comment.
fixed @haim-kermany please verify it is working as expected (by my testing it is)
|
the code works as eccpected, tnx |
Co-authored-by: Adi Sosnovich <[email protected]>
…nLines must be called
No description provided.