Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add info message just when needed #297

Merged
merged 8 commits into from
Jan 14, 2024
Merged

add info message just when needed #297

merged 8 commits into from
Jan 14, 2024

Conversation

olasaadi99
Copy link
Contributor

shortest solution

@olasaadi99 olasaadi99 requested a review from adisos December 26, 2023 15:10
adisos
adisos requested changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, added an initial comment.. you can now update the expected test output files and verify the resulting output reports, to make sure the info message is indeed added when relevant.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 27, 2023
@olasaadi99 olasaadi99 marked this pull request as ready for review December 27, 2023 08:22
@olasaadi99 olasaadi99 requested a review from adisos December 27, 2023 08:22
adisos
adisos requested changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small comments

@adisos adisos requested a review from haim-kermany December 27, 2023 09:27
haim-kermany
haim-kermany previously approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@haim-kermany haim-kermany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine with me

@olasaadi99 olasaadi99 force-pushed the 294_info_message_sec branch from 8933412 to 49e3b3b Compare January 4, 2024 11:40
@olasaadi99 olasaadi99 linked an issue Jan 9, 2024 that may be closed by this pull request
The info message should not be always added to the output #294
Closed
adisos
adisos requested changes Jan 10, 2024
View reviewed changes
haim-kermany
haim-kermany reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@haim-kermany haim-kermany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please notice that a big change in output.go was merged to the main branch today.
please merge from main to your branch

@olasaadi99 olasaadi99 force-pushed the 294_info_message_sec branch from 49e3b3b to c060cae Compare January 14, 2024 12:12
@olasaadi99 olasaadi99 requested a review from adisos January 14, 2024 13:09
adisos
adisos requested changes Jan 14, 2024
View reviewed changes
@olasaadi99 olasaadi99 merged commit ff6e34c into main Jan 14, 2024
@olasaadi99 olasaadi99 deleted the 294_info_message_sec branch January 14, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haim-kermany haim-kermany haim-kermany left review comments

@adisos adisos adisos approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The info message should not be always added to the output
3 participants
@olasaadi99 @haim-kermany @adisos