Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support md output format with all_subnets analysis type #314

Merged
merged 6 commits into from
Jan 14, 2024
Merged

Support md output format with all_subnets analysis type #314

merged 6 commits into from
Jan 14, 2024

Conversation

olasaadi99
Copy link
Contributor

No description provided.

@olasaadi99 olasaadi99 linked an issue Jan 9, 2024 that may be closed by this pull request
Extend supported ouput formats for certain analysis types #291
Closed
@olasaadi99 olasaadi99 requested a review from adisos January 9, 2024 09:51
@olasaadi99 olasaadi99 marked this pull request as ready for review January 9, 2024 11:31
adisos
adisos requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@adisos adisos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add a test that checks this new output

also, added a few comments.

cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
pkg/vpcmodel/mdOutput.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 13, 2024
@olasaadi99 olasaadi99 merged commit c77e888 into main Jan 14, 2024
4 checks passed
@olasaadi99 olasaadi99 deleted the 291_support_md_allsubnets branch January 14, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisos adisos adisos approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend supported ouput formats for certain analysis types
2 participants
@olasaadi99 @adisos