Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept a description of a connection in the cli and translate it to co… #319

Merged
merged 12 commits into from
Jan 15, 2024
Merged

accept a description of a connection in the cli and translate it to co… #319

merged 12 commits into from
Jan 15, 2024

Conversation

olasaadi99
Copy link
Contributor

…mmon.ConnectionSet

@olasaadi99 olasaadi99 requested a review from ShiriMoran January 11, 2024 08:42
@olasaadi99 olasaadi99 linked an issue Jan 11, 2024 that may be closed by this pull request
For explainability: accept a decription of a connection in the cli and translate it to common.ConnectionSet #315
Closed
ShiriMoran
ShiriMoran requested changes Jan 11, 2024
View reviewed changes
cmd/analyzer/main.go Outdated Show resolved Hide resolved
cmd/analyzer/main.go Outdated Show resolved Hide resolved
cmd/analyzer/parse_args.go Show resolved Hide resolved
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
@ShiriMoran
Copy link
Contributor

Much better :-)
To make the parms complete, please add to AnalysisType another possible value query and add the following validity checks:

  1. protocol must be specified for AnalysisType query
  2. All the new parms can be specified only if AnalysisType is query

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 14, 2024
@olasaadi99 olasaadi99 requested a review from ShiriMoran January 14, 2024 12:54
@ShiriMoran
Copy link
Contributor

Looks good, a few more minor comments

ShiriMoran
ShiriMoran requested changes Jan 14, 2024
View reviewed changes
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
cmd/analyzer/parse_args.go Show resolved Hide resolved
@ShiriMoran ShiriMoran requested a review from adisos January 14, 2024 15:38
adisos
adisos requested changes Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename "query" analysis type to be "explain" instead (@ShiriMoran confirmed the renaming does make sense).
Added few examples in comments where to apply this change, go over all relevant places to change.

pkg/vpcmodel/output.go Outdated Show resolved Hide resolved
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
adisos
adisos reviewed Jan 14, 2024
View reviewed changes
cmd/analyzer/main.go Outdated Show resolved Hide resolved
adisos
adisos reviewed Jan 14, 2024
View reviewed changes
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
ShiriMoran
ShiriMoran requested changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@ShiriMoran ShiriMoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done.
Just one comment: please let me mark as resolve my comments, so that I can easily follow them

cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
@olasaadi99 olasaadi99 changed the title accept a decription of a connection in the cli and translate it to co… accept a description of a connection in the cli and translate it to co… Jan 15, 2024
@olasaadi99 olasaadi99 merged commit f50617b into main Jan 15, 2024
4 checks passed
@olasaadi99 olasaadi99 deleted the 315_connection_description branch January 15, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiriMoran ShiriMoran ShiriMoran approved these changes

@adisos adisos adisos approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For explainability: accept a decription of a connection in the cli and translate it to common.ConnectionSet
3 participants
@olasaadi99 @ShiriMoran @adisos