767 sg nacl fields print order #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivnevo
requested changes
Sep 5, 2024
…into 767_sg_nacl_fields_print_order
zivnevo
reviewed
Sep 5, 2024
| @@ -72,7 +72,7 @@ func (na *AWSNACLAnalyzer) GetNACLRule(index int) (ruleStr string, ruleRes *comm | |||
| minPort, | |||
| maxPort, | |||
| ) | |||
| connStr = fmt.Sprintf("protocol: %s, dstPorts: %d-%d", protocol, minPort, maxPort) | |||
| portsStr = fmt.Sprintf(", dstPorts: %d-%d", minPort, maxPort) | |||
| case protocolICMP: | |||
There was a problem hiding this comment.
Are we OK with ICMP? I didn't see an example output
There was a problem hiding this comment.
- Indeed, there is no such example; moreover, I did not find an example that enables only icmp in the inputs file. Perhaps such an example should be added; does not seem related to this PR.
- Looking at the code - indeed it seems that the extra ICMP parms are ignored in the returned string; they were ignored from the beginning, nothing new to this PR.
- Moreover, looking at the code I do not understand why the printing function of conns was not used in the first place for the returned
ruleStr.
Not sure whether to fix it here or open a new issue and ask Ola what she had in mind. See also next comment
There was a problem hiding this comment.
fixed; At the moment we do not have an example of an icmp rule in aws
We do have an example in IBM (acl5) that is not yet used in explain tests; I'll add a test
There was a problem hiding this comment.
acl5 does not have any instances
Need to add examples of NACL rules with reference to ICMP type and code in both IBM and AWS
#860
zivnevo
requested changes
Sep 9, 2024
Co-authored-by: Ziv Nevo <[email protected]>
Co-authored-by: Ziv Nevo <[email protected]>
zivnevo
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.