Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert vpcconfig methods to functions #902

Merged
merged 8 commits into from
Nov 21, 2024
Merged

convert vpcconfig methods to functions #902

merged 8 commits into from
Nov 21, 2024

Conversation

olasaadi99
Copy link
Contributor

No description provided.

@haim-kermany
Copy link
Contributor

there is a new lint error in a drawio old code. however, I didnt figure out what is the problem @zivnevo

@zivnevo
Copy link
Member

zivnevo commented Nov 11, 2024

there is a new lint error in a drawio old code. however, I didnt figure out what is the problem @zivnevo

See here

@haim-kermany
Copy link
Contributor

@olasaadi99 , please see @zivnevo fix in another branch.
to avoid conflicts, I will not fix it here

@olasaadi99 olasaadi99 requested a review from zivnevo November 20, 2024 08:58
Copy link
Member

@zivnevo zivnevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@olasaadi99 olasaadi99 merged commit 7816dee into main Nov 21, 2024
4 checks passed
@olasaadi99 olasaadi99 deleted the 348_vpcconfig branch November 21, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit VPCConfig methods, consider converting to functions or methods for different structs
3 participants