Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

855 grouping legal graph #908

Merged
merged 41 commits into from
Oct 10, 2024
Merged

855 grouping legal graph #908

merged 41 commits into from
Oct 10, 2024

Conversation

ShiriMoran
Copy link
Contributor

No description provided.

@ShiriMoran
test that demonstrates the problem - that the resulting grouped cidr …
ad8c18f 
…lines do not form a legal graph
@ShiriMoran
Merge remote-tracking branch 'origin/main' into 855_grouping_legal_graph
7c6a90f
@ShiriMoran
added relevant tests to work with while developing
2ae832b
@ShiriMoran
towards solution of #855 added (not yet checked) code to create a map…
782abe3 
… from endpoints name to their IP presentation
@ShiriMoran
Merge branch 'main' into 855_grouping_legal_graph
21e2916
@ShiriMoran
code to add edges; not yet checked
4d6338f
@ShiriMoran
refactor: new code to another file
67b52a9
@ShiriMoran
self CR fixed
7fd6f41
@ShiriMoran
added new parm to tests
b5fe16a
@ShiriMoran
Export parm
564c734
@ShiriMoran
initialization bug fixes
cd24c4d
@ShiriMoran
typo bug fix
a18daa4
@ShiriMoran
added to test name and added test; test not working yet (same as before)
ded2434
@ShiriMoran
use NameForAnalyzerOut(..) instead of Name()
90f2de4
@ShiriMoran
bug fix, test is now working properly
bb14f73
@ShiriMoran
added tests; with grouping not working properly yet
0bed373
@ShiriMoran
somehow it got deleted
9ba4bc0
@ShiriMoran
generalization
59fbb7c
@ShiriMoran
added todos as to what should be done
48169a9
@ShiriMoran
refactored first 3 stages to work with srcToDst and dstToSrc
8ad74a9
@ShiriMoran
typo fix
189752c
@ShiriMoran
computations adjustments
ab47848
@ShiriMoran
adding edges
d5f418a
@ShiriMoran
add edges
26b43f1
@ShiriMoran
fix bug
d53a243
@ShiriMoran
not working since external networks are oblivious to sub cidrs
06087a1
@ShiriMoran
restoring the older version - which now seems ok, given that adding t…
b4ca0b6 
…he line in earlier stage does not work due to the essence of ExternalNetwork
@ShiriMoran
removed temp code
488ff33
@ShiriMoran ShiriMoran linked an issue Oct 8, 2024 that may be closed by this pull request
inconsistency in html graph w.r.t. external cidrs #855
Closed
@ShiriMoran ShiriMoran marked this pull request as draft October 9, 2024 06:13
@ShiriMoran ShiriMoran closed this Oct 9, 2024
@ShiriMoran ShiriMoran reopened this Oct 9, 2024
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Oct 9, 2024
@ShiriMoran ShiriMoran marked this pull request as ready for review October 9, 2024 08:50
zivnevo
zivnevo requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@zivnevo zivnevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make grouping an enum - NoGrouping, Grouping, GroupingWithConsistencyEdges

@ShiriMoran
Copy link
Contributor Author

GroupingWithConsistencyEdges

And NoGroupingWithConsistencyEdges

zivnevo
zivnevo reviewed Oct 9, 2024
View reviewed changes
pkg/vpcmodel/groupingGraphical.go Outdated Show resolved Hide resolved
pkg/vpcmodel/groupingGraphical.go Outdated Show resolved Hide resolved
pkg/vpcmodel/groupingGraphical.go Outdated Show resolved Hide resolved
pkg/vpcmodel/groupingGraphical.go Outdated Show resolved Hide resolved
@ShiriMoran ShiriMoran merged commit c5cdea5 into main Oct 10, 2024
4 checks passed
@ShiriMoran ShiriMoran deleted the 855_grouping_legal_graph branch October 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haim-kermany haim-kermany haim-kermany approved these changes

@zivnevo zivnevo zivnevo approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistency in html graph w.r.t. external cidrs
3 participants
@ShiriMoran @zivnevo @haim-kermany