minor adjustments to health thrower, reduced medic rpg ammo cost to 15 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clipsize reduced to 75, ammoprice increased, reduced alpha on particles so players can see, decreased cost of medic rpg ammo for consistency with demo's rockets, reduced spore launcher ammo price from 15->10
this might eventually get reverted
wrefgtzweve
reviewed
Jan 27, 2024
| @@ -163,13 +163,13 @@ SWEP.Animations = { | |||
| Time = 0.5, | |||
| ShellEjectAt = 0, | |||
| RestoreAmmo = 1, | |||
| SoundTable = { { s = "", p = 100, v = 75, t = 0.1, c = CHAN_ITEM, ind = 1, bg = 1, } }, | |||
| -- SoundTable = { { s = "", p = 100, v = 75, t = 0.1, c = CHAN_ITEM, ind = 1, bg = 1, } }, | |||
There was a problem hiding this comment.
dont comment these out, just delete them
wrefgtzweve
reviewed
Jan 27, 2024
| if CLIENT then | ||
| SWEP.Hook_ModifyBodygroups = function(wep, data) | ||
| local vm = data.vm | ||
| -- local wm = true |
wrefgtzweve
reviewed
Jan 27, 2024
| p:SetVelocity(((Hitpos - Startpos):GetNormal() * math.random(500, 800)) + VectorRand() * math.random(1, 60) + Vector(0,0,20)) | ||
| p:SetCollide(true) | ||
| p:SetColor(40, 40, 40) | ||
| for e = 1, 2 do |
There was a problem hiding this comment.
if e isn't used replace it with _
| p:SetCollide(true) | ||
| p:SetColor(40, 40, 40) | ||
| for e = 1, 2 do | ||
| local g = self.Emitter:Add("particles/smokey", Startpos) |
There was a problem hiding this comment.
instead of g this can be something like particle, no need for 1 char vars. it just makes the code harder to read.
| @@ -5,7 +5,7 @@ function EFFECT:Init(data) | |||
| has_burner = true | |||
| end | |||
| local light = DynamicLight( math.random( 0, 9999999 ) ) | |||
| if(light) then | |||
| if (light) then | |||
There was a problem hiding this comment.
you can remove the useless parentheses here
| @@ -19,7 +19,7 @@ function EFFECT:Init(data) | |||
| light.Size = 128; | |||
| light.Decay = 64; | |||
| light.Brightness = 3; | |||
| light.DieTime = CurTime()+1; | |||
| light.DieTime = CurTime() + 1; | |||
There was a problem hiding this comment.
the ; can entirely be removed
| @@ -28,7 +28,7 @@ function EFFECT:Init(data) | |||
|
|
|||
| local FlameEmitter = ParticleEmitter(data:GetOrigin()) | |||
|
|
|||
| for i=0, 16 do | |||
| for i = 0, 16 do | |||
There was a problem hiding this comment.
if i isn't used replace it with _
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clipsize reduced to 75, ammoprice increased, reduced alpha on particles so players can see, decreased cost of medic rpg ammo for consistency with demo's rockets, reduced spore launcher ammo price from 15->10