Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: publishing prerelease requires explicit tag #7910

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Nov 14, 2024

BREAKING CHANGE: When publishing a package with a pre-release version, you must explicitly specify a tag.

ref: npm/statusboard#898

@reggi reggi requested a review from a team as a code owner November 14, 2024 17:56
@reggi
Copy link
Contributor Author

reggi commented Nov 14, 2024

this does not implement rfc 7

@reggi
Copy link
Contributor Author

reggi commented Nov 25, 2024

maybe check should go on line 125 after tarball pack

@reggi
Copy link
Contributor Author

reggi commented Nov 25, 2024

or within async #getManifest

@wraithgar wraithgar changed the title fix!: publishing prerelease requires tag fix!: publishing prerelease requires explicit tag Nov 25, 2024
wraithgar
wraithgar previously approved these changes Nov 25, 2024
@reggi reggi force-pushed the reggi/abort-no-prerelease-tag branch 2 times, most recently from 55d74be to 3a43aa5 Compare November 25, 2024 16:58
@reggi reggi force-pushed the reggi/abort-no-prerelease-tag branch from 3a43aa5 to 03b8d32 Compare November 25, 2024 16:59
@wraithgar wraithgar merged commit 16b7367 into latest Nov 25, 2024
20 checks passed
@wraithgar wraithgar deleted the reggi/abort-no-prerelease-tag branch November 25, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants