Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 9.9.4 #7929

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 21, 2024

@github-actions github-actions bot requested a review from a team as a code owner November 21, 2024 19:06
Copy link
Contributor Author

github-actions bot commented Nov 21, 2024

Release Manager

Release workflow run: https://github.com/npm/cli/actions/runs/11961654106

Release Checklist for v9.9.4

  • 1. Checkout the release branch

    Ensure git status is not dirty on this branch after resetting deps. If it is, then something is probably wrong with the automated release process.

    gh pr checkout 7929 --force
    npm run resetdeps
    node scripts/git-dirty.js
  • 2. Check CI status

    gh pr checks --watch
  • 3. Publish the CLI and workspaces

    Warning:
    This will publish all updated workspaces to latest, prerelease or backport depending on their version, and will publish the CLI with the dist-tag set to next-9.

    Note:
    The --test argument can optionally be omitted to run the publish process without running any tests locally.

    node scripts/publish.js --test
  • 4. Optionally install and test [email protected] locally

    npm --version
    npm whoami
    npm help install
    # etc
  • 5. Set latest dist-tag to newly published version

    Warning:
    NOT FOR PRERELEASE: Do not run this step for prereleases or if 9 is not being set to latest.

    node . dist-tag add [email protected] latest
  • 6. Trigger docs.npmjs.com update

    gh workflow run update-cli.yml --repo npm/documentation
  • 7. Approve and Merge release PR

    gh pr review --approve
    ```sh
    
    ```sh
    gh pr merge --rebase
    git checkout release/v9
    git fetch
    git reset --hard origin/release/v9
    node . run resetdeps
  • 8. Wait For Release Tags

    Warning:
    The remaining steps all require the GitHub tags and releases to be created first. These are done once this PR has been labelled with autorelease: tagged.

    Release Please will run on the just merged release commit and create GitHub releases and tags for each package. The release bot will will comment on this PR when the releases and tags are created.

    Note:
    The release workflow also includes the Node integration tests which do not need to finish before continuing.

    You can watch the release workflow in your terminal with the following command:

    gh run watch `gh run list -R npm/cli -w release -b release/v9 -L 1 --json databaseId -q ".[0].databaseId"`
    
  • 9. Mark GitHub Release as latest

    Warning:
    You must wait for CI to create the release tags before running this step. These are done once this PR has been labelled with autorelease: tagged.

    Release Please will make GitHub Releases for the CLI and all workspaces, but GitHub has UI affordances for which release should appear as the "latest", which should always be the CLI. To mark the CLI release as latest run this command:

    gh release -R npm/cli edit v9.9.4 --latest
  • 10. Open nodejs/node PR to update npm to latest

    Warning:
    You must wait for CI to create the release tags before running this step. These are done once this PR has been labelled with autorelease: tagged.

    Trigger the Create Node PR action. This will open a PR on nodejs/node to the main branch.

    Note:
    The resulting PR may need to be labelled if it is not intended to land on old Node versions.

    First, sync our fork of node with the upstream source:

    gh repo sync npm/node --source nodejs/node --force

    Then, if we are opening a PR against the latest version of node:

    gh workflow run create-node-pr.yml -f spec=next-9

    If the PR should be opened on a different branch (such as when doing backports) then run it with -f branch=<BRANCH_NAME>. There is also a shortcut to target a specific Node version by specifying a major version number with -f branch=18 (or similar).

    For example, this will create a PR on nodejs/node to the v16.x-staging branch:

    gh workflow run create-node-pr.yml -f spec=next-9 -f branch=16
  • 11. Label and fast-track nodejs/node PR

    Note:
    This requires being a nodejs collaborator. This could be you!

    • Thumbs-up reaction on the Fast-track comment
    • Add an LGTM / Approval
    • Add request-ci label to get it running CI
    • Add commit-queue label once everything is green

@github-actions github-actions bot force-pushed the release-please--branches--release/v9 branch 2 times, most recently from de908e5 to a6ea7b8 Compare November 21, 2024 21:07
@github-actions github-actions bot force-pushed the release-please--branches--release/v9 branch from a6ea7b8 to b6ab4f5 Compare November 21, 2024 21:08
@wraithgar wraithgar merged commit 64763a3 into release/v9 Nov 21, 2024
28 of 37 checks passed
@wraithgar wraithgar deleted the release-please--branches--release/v9 branch November 21, 2024 21:59
Copy link
Contributor Author

🤖 Release is at https://github.com/npm/cli/releases/tag/v9.9.4 🌻

Copy link
Contributor Author

github-actions bot commented Nov 21, 2024

Release Workflow

🚨🚨🚨

@npm/cli-team: The post-release workflow failed for this release. Manual steps may need to be taken after examining the workflow output.

🚨🚨🚨

@sjgupta19
Copy link

The workflow failed which I think did not publish the v9.9.4

@wraithgar
Copy link
Member

The workflow failure was in the post-release node citgm tests. This repo does not auto publish, it's done manually. It does look like that didn't succeed. Thanks for the heads up.

@sjgupta19
Copy link

Is there a timeline for releasing the v9.9.4? there are certain blockers on our side due to CVE that is supposed to be fixed in this new version.

@wraithgar
Copy link
Member

npm@9 is not being actively maintained and has no more planned updates. We made 9.9.4 mostly as a test of our backporting workflow.

9.9.4 was published yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants