-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to @npmcli/package-json #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
deps/package-json
branch
6 times, most recently
from
January 18, 2024 19:29
b916711
to
6cacec6
Compare
wraithgar
force-pushed
the
deps/package-json
branch
from
January 18, 2024 20:33
6cacec6
to
f5a346a
Compare
lukekarrys
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow these new tests are really nice to read!
Merged
This was referenced Jan 19, 2024
wraithgar
pushed a commit
that referenced
this pull request
Jan 23, 2024
🤖 I have created a release *beep* *boop* --- ## [7.0.4](v7.0.3...v7.0.4) (2024-01-22) ### Bug Fixes * [`7ebc853`](7ebc853) [#194](#194) envs: revert behavior of array in npm config (#194) (@wraithgar, @siemhesda) * [`bf5f419`](bf5f419) [#192](#192) code formatting (@wraithgar) * [`b6f7f93`](b6f7f93) [#192](#192) remove unreachable code path (@wraithgar) * [`865d556`](865d556) [#192](#192) remove is-windows test fixture code from module (@wraithgar) * [`c47a91a`](c47a91a) [#192](#192) update code to use @npmcli/run-script (@wraithgar) ### Dependencies * [`648b0ed`](648b0ed) [#192](#192) remove read-package-json-fast * [`04a4600`](04a4600) [#192](#192) add `@npmcli/[email protected]` ### Chores * [`155c434`](155c434) [#192](#192) rewrite tests (@wraithgar) * [`64a3503`](64a3503) [#192](#192) add spawk (@wraithgar) * [`b47b660`](b47b660) [#192](#192) remove require-inject (@wraithgar) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot had to go into this, mostly making the tests real.
Closes: #190