Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps/proc log #198

Merged
merged 2 commits into from
Apr 12, 2024
Merged

deps/proc log #198

merged 2 commits into from
Apr 12, 2024

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar requested a review from a team as a code owner April 12, 2024 19:00
Copy link
Contributor

@lukekarrys lukekarrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove all mentions of banner from the README.

lib/run-script-pkg.js Outdated Show resolved Hide resolved
lib/run-script-pkg.js Outdated Show resolved Hide resolved
@wraithgar wraithgar force-pushed the deps/proc-log branch 2 times, most recently from 5430165 to 2b11904 Compare April 12, 2024 19:29
test/run-script-pkg.js Outdated Show resolved Hide resolved
@wraithgar wraithgar force-pushed the deps/proc-log branch 2 times, most recently from e90d2e5 to be5f07d Compare April 12, 2024 19:38
@wraithgar wraithgar requested a review from lukekarrys April 12, 2024 19:38
lukekarrys
lukekarrys previously approved these changes Apr 12, 2024
BREAKING CHANGE: The existing banner is now emitted using `proc-log`
instead of `console.log`.  It is always emitted. Consuming libraries can
decide under which situations to show the banner.
@wraithgar wraithgar merged commit 5f9cbcf into main Apr 12, 2024
20 checks passed
@wraithgar wraithgar deleted the deps/proc-log branch April 12, 2024 20:00
@github-actions github-actions bot mentioned this pull request Apr 12, 2024
lukekarrys pushed a commit that referenced this pull request Apr 12, 2024
🤖 I have created a release *beep* *boop*
---


## [8.0.0](v7.0.4...v8.0.0)
(2024-04-12)

### ⚠️ BREAKING CHANGES

* The existing banner is now emitted using `proc-log` instead of
`console.log`. It is always emitted. Consuming libraries can decide
under which situations to show the banner.

### Features

*
[`5f9cbcf`](5f9cbcf)
[#198](#198) output using proc-log
(@wraithgar)

### Dependencies

*
[`021758b`](021758b)
[#198](#198) `[email protected]`

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants