-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps/proc log #198
Merged
Merged
deps/proc log #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wraithgar
commented
Apr 12, 2024
- deps: [email protected]
- feat!: output using proc-log
lukekarrys
reviewed
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove all mentions of banner
from the README.
lukekarrys
reviewed
Apr 12, 2024
wraithgar
force-pushed
the
deps/proc-log
branch
from
April 12, 2024 19:14
9b7ad2a
to
fb8f731
Compare
lukekarrys
reviewed
Apr 12, 2024
wraithgar
force-pushed
the
deps/proc-log
branch
2 times, most recently
from
April 12, 2024 19:29
5430165
to
2b11904
Compare
wraithgar
commented
Apr 12, 2024
wraithgar
force-pushed
the
deps/proc-log
branch
2 times, most recently
from
April 12, 2024 19:38
e90d2e5
to
be5f07d
Compare
lukekarrys
previously approved these changes
Apr 12, 2024
BREAKING CHANGE: The existing banner is now emitted using `proc-log` instead of `console.log`. It is always emitted. Consuming libraries can decide under which situations to show the banner.
wraithgar
force-pushed
the
deps/proc-log
branch
from
April 12, 2024 19:42
be5f07d
to
eed54fd
Compare
lukekarrys
approved these changes
Apr 12, 2024
nishantms
approved these changes
Apr 12, 2024
Merged
lukekarrys
pushed a commit
that referenced
this pull request
Apr 12, 2024
🤖 I have created a release *beep* *boop* --- ## [8.0.0](v7.0.4...v8.0.0) (2024-04-12) ###⚠️ BREAKING CHANGES * The existing banner is now emitted using `proc-log` instead of `console.log`. It is always emitted. Consuming libraries can decide under which situations to show the banner. ### Features * [`5f9cbcf`](5f9cbcf) [#198](#198) output using proc-log (@wraithgar) ### Dependencies * [`021758b`](021758b) [#198](#198) `[email protected]` --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.