374 use tar map to reduce duplicated code #547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Robinlovelace
commented
Oct 31, 2024
Robinlovelace
commented
- Update gitignore
- comment-out everything after school routing, for tests
|
Flow diagram a lot simpler now! Working with Zhao on this and heads-up @juanfonsecaLS1, here's a auto-generated flow chart..
|
|
Update, looking promising!
|
|
One thought: this could lead to a big increase in memory usage, because it relies on all 4 route types being loaded into memory at the same time. I think we can tackle this by keeping only the route segments (not the routes also), to reduce duplication. |
|
My thinking on this: we should switch to LADs as regions if we go for this approach. |
|
Superceded by #548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.