Merge pull request #14 from nrccua/fix/missing_path_params

[E4E-87]: Allow an empty input body to be passed to be passed in variables

CHANGELOG.md

@@ -2,6 +2,22 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [1.3.2](https://github.com/nrccua/apollo-rest-utils/compare/1.3.1...1.3.2) (2022-01-07)
+
+
+### Changes
+
+* [E4E-87]: Allow some params to be optional, duh ([c507d2b](https://github.com/nrccua/apollo-rest-utils/commit/c507d2b2c81eda25cf4b7c75b5a77e0eba20309c))
+* [E4E-87]: 1.3.1 ([494dae2](https://github.com/nrccua/apollo-rest-utils/commit/494dae20089d6bd9dff3d8942026dc1abfc059f0))
+
+### [1.3.1](https://github.com/nrccua/apollo-rest-utils/compare/1.3.0...1.3.1) (2022-01-07)
+
+
+### Changes
+
+* [E4E-87]: Allow an empty input body to be passed to be passed in variables ([4b67e40](https://github.com/nrccua/apollo-rest-utils/commit/4b67e4033b6773a682b4363224076e9dcdf0f828))
+* [E4E-87]: 1.3.0 ([cbda2b6](https://github.com/nrccua/apollo-rest-utils/commit/cbda2b6cef2483571b99b99943777aafb21c2449))
+
 ## [1.3.0](https://github.com/nrccua/apollo-rest-utils/compare/1.2.2...1.3.0) (2022-01-06)
 
 

lib/generateRoutes/index.ts

@@ -85,7 +85,9 @@ export function typeObjectFromParams(
   params.forEach(p => {
     const paramObject = p as ParameterObject;
     if (paramObject.name) {
-      typeString += `${_.camelCase(paramObject.name)}: ${typeOfParam(paramObject)}; `;
+      typeString += `${_.camelCase(paramObject.name)}${
+        paramObject.required || paramObject.in === 'path' ? '' : '?'
+      }: ${typeOfParam(paramObject)}; `;
     }
   });
 

lib/types/restSchema/index.ts

@@ -25,7 +25,11 @@ export type RestResponse<T> = T extends IRestEndpoint<infer U, unknown> ? U : ne
 
 export type RestRequest<T> = T extends IRestEndpoint<unknown, infer U> ? U : never;
 
-export type Input<T> = T | { input: T };
+// Allow for either:
+// 1. All fields to put into an input object
+// or
+// 2. Allow an empty input object to overcome a bug in apollo-link-rest where PATCH/POST/PUT barfs with no body
+export type Input<T> = (T & { input?: Record<string, never> }) | { input: T };
 
 export interface IEndpointOptions<T, U> {
   endpoint: IRestEndpoint<T, U>;

package.json

@@ -69,5 +69,5 @@
     "update:version:major": "standard-version --release-as major",
     "update:version:minor": "standard-version --release-as minor"
   },
-  "version": "1.3.0"
+  "version": "1.3.2"
 }