-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bulk method #13
Conversation
8df57c8
to
6fa9e06
Compare
Hello, I can see several problems with this approach:
I updated PR #9, I'm still thinking about the best approach. |
@cgroschupp can you check something for me? Inside PR #9, the status code of a bulk creation is |
Only the Post request returns a status code of 201. I have changed the code. |
f544c92
to
0ab3f50
Compare
0ab3f50
to
56237ab
Compare
I think the first point is covered by my additional commit. |
I merged PR #9, with some modifications. I see you added |
I close this PR in favor of #9 |
Because the bulk endpoint can handle create, update and delete operations, it is not necessary to have a separate method for each operation, so I implement it differently than in #9
Docs: https://desec.readthedocs.io/en/latest/dns/rrsets.html#bulk-operations