Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replacing HTML content body with plain text error on 503 #6

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix: replacing HTML content body with plain text error on 503 #6

merged 2 commits into from
Aug 22, 2023

Conversation

DazWilkin
Copy link
Contributor

Fixes #5

@ldez ldez changed the title Trap Porkbun 503s replacing HTML message body with plain text error. fix: replacing HTML content body with plain text error on 503 Aug 22, 2023
@ldez ldez added the bug Something isn't working label Aug 22, 2023
ldez
ldez approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez enabled auto-merge (squash) August 22, 2023 23:31
@ldez ldez merged commit 926336f into nrdcg:master Aug 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If Porkbun API endpoint results in 503, HTML is returned in the response body
2 participants
@DazWilkin @ldez