use i18next interpolation instead of concatenating strings

nrenner · Oct 20, 2024 · 6606d8b · 6606d8b
1 parent bb3bfba
commit 6606d8b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/js/control/TrackAnalysis.js b/js/control/TrackAnalysis.js
@@ -180,13 +180,19 @@ BR.TrackAnalysis = L.Class.extend({
                         case 'surface':
                         case 'smoothness':
                             if (typeof analysis[tagName][wayTagParts[1]] === 'undefined') {
-                                let formattedName = i18next.t([
-                                    'sidebar.analysis.data.' + tagName + '.' + wayTagParts[1],
-                                    wayTagParts[1],
-                                ]);
+                                let formattedName;
+
                                 if (tagName.indexOf('maxspeed') === 0) {
-                                    formattedName += ' km/h';
+                                    formattedName = i18next.t('sidebar.analysis.data.maxspeed', {
+                                        maxspeed: wayTagParts[1],
+                                    });
+                                } else {
+                                    formattedName = i18next.t([
+                                        'sidebar.analysis.data.' + tagName + '.' + wayTagParts[1],
+                                        wayTagParts[1],
+                                    ]);
                                 }
+
                                 analysis[tagName][wayTagParts[1]] = {
                                     formatted_name: formattedName,
                                     name: wayTagParts[1],

diff --git a/locales/en.json b/locales/en.json
@@ -338,7 +338,8 @@
                 "horrible": "Horrible",
                 "very_horrible": "Very Horrible",
                 "impassable": "Impassable"
-            }
+            },
+            "maxspeed": "{{maxspeed}} km/h"
         },
       "header": {
         "highway": "Highway",