Client-side track formatting #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use togpx fork for now (outdated), see PR: tyrasd/togpx#11
- with PR 11 merged - referencing jxon fork with namespace prefixes fixed
+ handle server voicehint time removed, times with 3 digits
to better match BRouter output
|
Did a couple of test rides with my usual post-processing and device setup in the last two weeks and also had a cursory look at the code and the exported files. No issues found so far, seems to work great. I'll add a couple of remarks to some existing GH issues later. Thanks @nrenner, this is a huge milestone to base the next round of features on. |
|
Thanks for testing and the feedback. Still want to do some more testing myself. |
This was referenced Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves track formatting to the client, accepting some code duplication.
Already loaded route segments are concatenated instead of making an additional server call to re-route the whole route for export. See discussion in #68 and previous discussions in brouter#91, brouter#196, #226, brouter#188.
Also introduces Jest for testing.
Depends on abrensch/brouter#298 for complete voice hints.