-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applications: slm: try to continue even no DNS record was sent #19701
applications: slm: try to continue even no DNS record was sent #19701
Conversation
Thank you for your contribution! Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
53d856f
to
bfb7fc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another good finding. The functions should be changed so that they do not fail in the scenarios where the number of the DNS addresses is unexpected.
2cd13a7
to
d1fa9c0
Compare
@@ -453,6 +453,7 @@ Modem libraries | |||
* :ref:`pdn_readme` library: | |||
|
|||
* Added the :c:func:`pdn_dynamic_params_get_v6` function to get PDN parameters for IPv6-only. | |||
* Changed logic DNS record expectation. Because ISP sends sometimes 1 and even 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Changed logic DNS record expectation. Because ISP sends sometimes 1 and even 0. | |
* Changed logic DNS record expectation, because ISP sometimes sends 1 and even 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
73ee8bd
to
6159bb1
Compare
f69eac8
to
8dea03e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits.
It would be nice to have some tests in https://github.com/nrfconnect/sdk-nrf/tree/main/tests/lib/pdn, though they can also be added in a follow up PR.
I'll trigger CI for this commit.
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 5af606c08731e46bbca1a60a3c41ea8775ac3a0b more detailssdk-nrf:
Github labels
List of changed files detected by CI (5)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
43275ff
to
b50e3ba
Compare
b50e3ba
to
577cd31
Compare
@tokangas Sorry, I've rebased the branch right after you added CI-Requested tag and bot removed it. |
577cd31
to
5ef88bc
Compare
a660f32
to
8e86873
Compare
8e86873
to
e009791
Compare
- We shouldn't expect 2 DNS records from ISP. Because it sends sometimes 1 and even 0. It must try to continue like in MOSH. - convert link_api_pdp_context_dynamic_params_get to pdn_pdp_context_dynamic_params_get and use it on both SLM and MOSH Signed-off-by: Oguzhan Turk <[email protected]> Co-authored-by: Eivind Jølsgard <[email protected]> Co-authored-by: Pekka Niskanen <[email protected]> Co-authored-by: Tommi Kangas <[email protected]> Co-authored-by: Tommi Rantanen <[email protected]>
e009791
to
5af606c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TaeZStkyoht Thanks for your contribution and patience with all requested changes! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and thanks for the patience @TaeZStkyoht 😄
We shouldn't expect 2 DNS records from ISP. Because it sends sometimes 1 and even 0. We must just try to continue to establish PPP connection.
Real world scenario:
ISP sends DNS records as:
MOSH was already working fine with allowing like that I've implemented here for SLM. We were using MOSH in at_cmd_mode on our product. However we want to use SLM; because, SLM is an application while MOSH is a sample. And we want to also be able to access GPIO command to swtich sim/eSim from outside easily. SLM is capable of doing it while MOSH not.
If this change is really directly not ok for you, I can also make it configurable with KConfig. By default can be false and we can set it to true on our project. Nevertheless, MOSH works like that, why not SLM?