Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: mesh: Fix scene recall for Light Ctrl server #19752

Merged

Conversation

akredalen
Copy link
Contributor

The Light Lightness Control Server was not correctly handling scene recalls. The Server now resumes the Lightness Controller automatically after a scene recall, fixing the known issue NCSDK-30033.

@akredalen akredalen requested review from a team as code owners January 6, 2025 12:07
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. labels Jan 6, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 6, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: f3a6e63940f19e8ef5d70cd46453efca50ad690f

more details

sdk-nrf:

PR head: f3a6e63940f19e8ef5d70cd46453efca50ad690f
merge base: 84ec4da2bfb18ecc3a6adffb4ae67cb520634e04
target head (main): cac49ac985664e9357e1c30691ce1091470c528b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
subsys
│  ├── bluetooth
│  │  ├── mesh
│  │  │  │ light_ctrl_srv.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 828
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_mesh
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@akredalen akredalen force-pushed the NCSDK-30033_mesh_scene_recall_fix branch from e709db3 to 56f1dbc Compare January 6, 2025 14:19
The Light Lightness Control Server now resumes the Lightness Controller
automatically after a scene recall, fixing the known issue NCSDK-30033.

Signed-off-by: Stine Akredalen <[email protected]>
@akredalen akredalen force-pushed the NCSDK-30033_mesh_scene_recall_fix branch from 56f1dbc to f3a6e63 Compare January 7, 2025 09:14
@akredalen akredalen requested a review from divipillai January 7, 2025 09:15
@akredalen akredalen removed the doc-required PR must not be merged without tech writer approval. label Jan 7, 2025
@rlubos
Copy link
Contributor

rlubos commented Jan 7, 2025

@nrfconnect/ncs-paladin Please review.

@rlubos rlubos merged commit 5a083ee into nrfconnect:main Jan 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants