emds: Fix size calculation required by emds entries on RRAM #19756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: b340f24f151768ef147b73b80ce44edfdfd78ada more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
The total size required by emds entries calculated more than what is actually being used. For RRAM, we don't need to align the data with write block size. We can write as many bytes as we want up to the size of write block size, thus we don't need to align writes with write block size. Signed-off-by: alperen sener <[email protected]>
m-alperen-sener
force-pushed
the
fix_emds_enries_total_size_calculation
branch
from
4e28ffd to
b340f24
Compare
Balaklaka
approved these changes
Jan 6, 2025
|
need to refactor the PR, actual data is still align according to write block size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total size required by emds entries calculated more than what is actually being used. For RRAM, we don't need to align the data with write block size. We can write as many bytes as we want up to the size of write block size, thus we don't need to align writes with write block size.