Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdfw_services: psa_crypto: use new tags for pointer-to-const members #19808

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonathannilsen
Copy link
Contributor

@jonathannilsen jonathannilsen commented Jan 8, 2025

Relevant changes are in the second commit.

The first commit is just regenerating zcbor code.

Rebased on top of #19583 which is needed to fix an unrelated compilation issue.

@jonathannilsen jonathannilsen requested review from a team as code owners January 8, 2025 16:26
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 8, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 8, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 493459fc660d9f6789fde161fe7d95337c6f1857
zephyr: PR head: c0cde2706b2bdd20340a4dbf454b5b0e1baec239

more details

sdk-nrf:

PR head: 493459fc660d9f6789fde161fe7d95337c6f1857
merge base: 37d64078780624552ae60c1cdb00ac1408598f11
target head (main): 509fa66004370f00faf13912cc6fced25dda6d6c
Diff

zephyr:

PR head: c0cde2706b2bdd20340a4dbf454b5b0e1baec239
merge base: 1e841e3e45ad9abf7174d6638e1771a9cc2dd126
target head (main): 47e589250c0f9128aa11f0c3d0a5f7e0d83fc2ba
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (28)
subsys
│  ├── sdfw_services
│  │  ├── services
│  │  │  ├── echo
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── echo_service_decode.c
│  │  │  │  │  ├── echo_service_decode.h
│  │  │  │  │  ├── echo_service_encode.c
│  │  │  │  │  ├── echo_service_encode.h
│  │  │  │  │  │ echo_service_types.h
│  │  │  ├── psa_crypto
│  │  │  │  ├── Kconfig
│  │  │  │  ├── psa_crypto_service.cddl
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── psa_crypto_service_decode.c
│  │  │  │  │  ├── psa_crypto_service_decode.h
│  │  │  │  │  ├── psa_crypto_service_encode.c
│  │  │  │  │  ├── psa_crypto_service_encode.h
│  │  │  │  │  │ psa_crypto_service_types.h
│  │  │  ├── reset_evt
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── reset_evt_service_decode.c
│  │  │  │  │  ├── reset_evt_service_decode.h
│  │  │  │  │  ├── reset_evt_service_encode.c
│  │  │  │  │  ├── reset_evt_service_encode.h
│  │  │  │  │  │ reset_evt_service_types.h
│  │  │  ├── sdfw_update
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── sdfw_update_service_decode.c
│  │  │  │  │  ├── sdfw_update_service_decode.h
│  │  │  │  │  ├── sdfw_update_service_encode.c
│  │  │  │  │  ├── sdfw_update_service_encode.h
│  │  │  │  │  │ sdfw_update_service_types.h
west.yml
zephyr
│  ├── include
│  │  ├── zephyr
│  │  │  ├── drivers
│  │  │  │  ├── clock_control
│  │  │  │  │  │ nrf_clock_control.h

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 144
    • sdk-zephyr test count: 6091
  • 🟡 Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ❌ test-low-level
    • 🟡 test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@jonathannilsen jonathannilsen added this to the 2.9.0-nRF54H20 milestone Jan 9, 2025
NordicBuilder and others added 2 commits January 10, 2025 10:48
Automatically created by Github Action

Signed-off-by: Nordic Builder <[email protected]>
Regenerate code using the current zcbor version.

Signed-off-by: Jonathan Nilsen <[email protected]>
@jonathannilsen jonathannilsen requested a review from a team as a code owner January 10, 2025 10:52
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 10, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@1e841e3 nrfconnect/sdk-zephyr#2397 nrfconnect/sdk-zephyr#2397/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

This lets the server loosen the required permissions when validating
pointers-to-const parameters so that only read permissions are required
for these.

Note that this CDDL update is not backwards compatible, and the
service version is bumped to 2.

Ref: NCSDK-31182

Signed-off-by: Jonathan Nilsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants