net: lib: nrf_cloud: Fix warnings on PGPS #19829
Open
+17
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new downloader library behaves slightly differently than the old download_client library. Specify the download protocol. Expect an -EPERM error when calling downloader_cancel() when download is already done. Also address potential build error with coap provisioning overlay. Signed-off-by: Pete Skeggs <[email protected]>
github-actions
bot
added
the
doc-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 77e223cb1ae2d0593e0f20c1fef501a70eef1cd9 more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
peknis
requested changes
Jan 10, 2025
Comment on lines
+300
to
+301
| * Fixed an issue with the :kconfig:option:`CONFIG_COAP_EXTENDED_OPTIONS_LEN_VALUE` Kconfig value | ||
| in the :file:`overlay-coap_nrf_provisioning.conf` file: the value was too small. |
There was a problem hiding this comment.
Please formulate as follows:
-
Fixed:
- An issue with an uninitialized variable in the :c:func:
handle_at_cmd_requestsfunction. - An issue with the too small :kconfig:option:
CONFIG_COAP_EXTENDED_OPTIONS_LEN_VALUEKconfig value
in the :file:overlay-coap_nrf_provisioning.conffile.
- An issue with an uninitialized variable in the :c:func:
| @@ -506,6 +508,9 @@ Libraries for networking | |||
| * :ref:`lib_azure_fota` | |||
| * :ref:`lib_fota_download` | |||
|
|
|||
| * :ref:`lib_nrf_cloud_pgps` library: | |||
|
|
|||
| * Fixed warning due to missing ``https`` download protocol. | |||
There was a problem hiding this comment.
Suggested change
| * Fixed warning due to missing ``https`` download protocol. | |
| * Fixed the warning due to missing ``https`` download protocol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new downloader library behaves slightly differently than the old download_client library.
Specify the download protocol. Expect an -EPERM error when calling downloader_cancel() when download is already done.
Also address potential build error with coap provisioning overlay.