Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: location: skip A-GNSS data request when no ephe/alm requested #19938

Merged

Conversation

tokangas
Copy link
Contributor

GNSS asks for some A-GNSS data, like UTC and iono parameters, once every 24 hours. This may have caused a separate A-GNSS data request for this data alone. The implementation has now been modified to skip such a request. All data is downloaded with the next ephemeris request, which happens approximately every two hours.

@tokangas tokangas requested a review from hiltunent January 16, 2025 08:17
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 16, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 16, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 8cbfab158e9a79e182c0f014fb755ae9f0a1b156

more details

sdk-nrf:

PR head: 8cbfab158e9a79e182c0f014fb755ae9f0a1b156
merge base: c9251c2c358d8e184999c9ae1d37b5d4a901d53c
target head (main): d5cd914eae77e7ccbb2cdc533e35267a42fb068f
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
lib
│  ├── location
│  │  │ method_gnss.c
tests
│  ├── lib
│  │  ├── location
│  │  │  ├── src
│  │  │  │  │ location_test.c

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 254
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@tokangas tokangas force-pushed the location_agnss_data_download_improvement branch from 4223036 to 5a73123 Compare January 16, 2025 10:07
GNSS asks for some A-GNSS data, like UTC and iono parameters, once every
24 hours. This may have caused a separate A-GNSS data request for this
data alone. The implementation has now been modified to skip such a
request. All data is downloaded with the next ephemeris request, which
happens approximately every two hours.

Signed-off-by: Tommi Kangas <[email protected]>
@tokangas tokangas force-pushed the location_agnss_data_download_improvement branch from 5a73123 to 8cbfab1 Compare January 16, 2025 10:57
@tokangas tokangas removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 16, 2025
@rlubos rlubos merged commit 588f19d into nrfconnect:main Jan 17, 2025
14 checks passed
@tokangas tokangas deleted the location_agnss_data_download_improvement branch January 17, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants