Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suit: Add SoC dependency in MCI #20024

Conversation

tomchy
Copy link
Contributor

@tomchy tomchy commented Jan 21, 2025

Add dependency on SoC in SUIT_MCI_IMPL symbol and refactor one of the tests to allow for such change.

Ref: NCSDK-NONE

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 21, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 21, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: abd302b8b04e3cfa106f068946a64c5d81c7f271

more details

sdk-nrf:

PR head: abd302b8b04e3cfa106f068946a64c5d81c7f271
merge base: fbec23918dc1b8da6eb796d4ec524634180857cd
target head (main): 188c9aa620721ba02357e09eeb32c859310fec3e
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (5)
subsys
│  ├── suit
│  │  ├── mci
│  │  │  ├── CMakeLists.txt
│  │  │  │ Kconfig
tests
│  ├── subsys
│  │  ├── suit
│  │  │  ├── cmake
│  │  │  │  │ test_template.cmake
│  │  │  ├── component_compatibility_check
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  │ prj.conf

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 117
  • ✅ Integration tests
    • ✅ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@tomchy tomchy force-pushed the bugfix/suit/NCSDK-NONE_Add_soc_dependency_in_mci branch 2 times, most recently from d24434b to 6eb113e Compare January 21, 2025 14:36
Use CMake to select MCI implementation, based on the SoC.
Use Kconfig to enable SDFW (common for all nordic platforms) or custom
implementation.
Refactor one of the tests to allow for such change.

Ref: NCSDK-NONE

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy force-pushed the bugfix/suit/NCSDK-NONE_Add_soc_dependency_in_mci branch from 6eb113e to abd302b Compare January 21, 2025 14:38
@tomchy tomchy marked this pull request as ready for review January 21, 2025 14:41
@tomchy tomchy requested review from a team as code owners January 21, 2025 14:41
@tomchy tomchy merged commit b91a4cf into nrfconnect:main Jan 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants