-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: smp_svr: fix overlay file #20033
Conversation
Fix include path in nrf9160dk_nrf52840_recovery.overlay file. Enable mcuboot shell. Signed-off-by: Juha Ylinen <[email protected]>
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 717c59d0d3a1856a31f2365be162abaa15c271f6 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)
Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have a changelog entry?
I think no, because this is fixing something that was already working previously. Not all bugs deserve mention on the changelog. Only those that are relevant to customers. |
Agreed, just wanted to check as the |
Fix include path in nrf9160dk_nrf52840_recovery.overlay file.
Enable mcuboot shell.