-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_rpc: Add functionality for invoking remote shell cmd via rpc #20060
base: main
Are you sure you want to change the base?
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 913980c1be51b1b4d0d3a5aa53659f6f90020bf4 more detailssdk-nrf:
Github labels
List of changed files detected by CI (7)
Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat, just a couple of nits found. I just wonder if this should belong to the "device information" group. This group was meant to be used for retrieving information about the device, such as hardware/software versions while running a shell command seems to be a more general/functionality. It won't block this if it's just me but I would move this to a separate group :).
samples/nrf_rpc/protocols_serialization/client/src/dev_info_shell.c
Outdated
Show resolved
Hide resolved
f11bc2e
to
79f941f
Compare
b59b401
to
aed9af2
Compare
The functionality allows the nrf_rpc client to invoke nrf_rpc server shell command and obtain the command's output. This commit adds the new nrf_rpc client shell subcommand: 'remote_shell' Example of use: rpc remote_shell device list devices: - clock@10e000 (READY) - gpio@10a000 (READY) - gpio@d8200 (READY) - gpio@50400 (READY) - psa-rng (READY) - uart@c7000 (READY) - uart@c6000 (READY) - spi@4a000 (READY) - rram-controller@5004b000 (READY) - mx25r6435f@0 (READY) - ieee802154 (READY) - temp@d7000 (READY) Signed-off-by: Lukasz Maciejonczyk <[email protected]>
aed9af2
to
913980c
Compare
The functionality allows the nrf_rpc client to invoke nrf_rpc server shell command and obtain the command's output.
This commit adds the new nrf_rpc client shell subcommand: 'remote_shell'.
Example of use:
rpc remote_shell device list
devices: