Fix heap corruption #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for allocation failure and log an error. The error aren't propagated as it needs more changes, but at least we can identify that allocation has failed. Signed-off-by: Chaitanya Tata <[email protected]>
While parsing the packet all TLV's are NULl terminated explicitly, so, take in to account the NULL terminating byte while memory allocation. Else, this overrides other memory causing hard to debug heap corruptions. Fixes SHEL-2754. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
fix_heap_corruption
branch
from
2da19d8 to
28cb907
Compare
This was referenced May 28, 2024
When using POSIX_API we need to define dummy prototype for compilation to succeed. Signed-off-by: Chaitanya Tata <[email protected]>
bama-nordic
approved these changes
May 29, 2024
D-Triveni
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.