Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle bad http respnse codes better (SOFIE-3616) #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Nov 5, 2024

About Me

This pull request is posted on behalf of the NRK

Type of Contribution

This is a: Bug fix

Current Behavior

PM doesn't handle bad response codes properly, so we can happen to store a bad response in the jsonDataCopy job.

New Behavior

bad (>=400) error responses are handled better.

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants