Skip to content

Commit

Permalink
fix(launch-template): remove playwright from browser cache
Browse files Browse the repository at this point in the history
Playwright recommends not caching the binaries since restoring from the
cache usually takes longer than just downloading from the CDN.

> Caching browser binaries is not recommended, since the amount of time
it takes to restore the cache is comparable to the time it takes to
download the binaries. Especially under Linux, operating system
dependencies need to be installed, which are not cacheable.

https://playwright.dev/docs/ci#caching-browsers
  • Loading branch information
barbados-clemens committed Nov 11, 2024
1 parent 4db8e6c commit 562fe45
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions launch-templates/linux.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ launch-templates:
key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|"browsers"'
paths: |
'../.cache/Cypress'
'../.cache/ms-playwright'
base-branch: 'main'
- name: Install Node Modules
uses: 'nrwl/nx-cloud-workflows/v4/workflow-steps/install-node-modules/main.yaml'
Expand All @@ -41,7 +40,6 @@ launch-templates:
key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|"browsers"'
paths: |
'../.cache/Cypress'
'../.cache/ms-playwright'
base-branch: 'main'
- name: Install Node Modules
uses: 'nrwl/nx-cloud-workflows/v4/workflow-steps/install-node-modules/main.yaml'
Expand All @@ -65,7 +63,6 @@ launch-templates:
key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|"browsers"'
paths: |
'../.cache/Cypress'
'../.cache/ms-playwright'
base-branch: 'main'
- name: Install Node Modules
uses: 'nrwl/nx-cloud-workflows/v4/workflow-steps/install-node-modules/main.yaml'
Expand All @@ -89,7 +86,6 @@ launch-templates:
key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|"browsers"'
paths: |
'../.cache/Cypress'
'../.cache/ms-playwright'
base-branch: 'main'
- name: Install Node Modules
uses: 'nrwl/nx-cloud-workflows/v4/workflow-steps/install-node-modules/main.yaml'
Expand All @@ -113,7 +109,6 @@ launch-templates:
key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|"browsers"'
paths: |
'../.cache/Cypress'
'../.cache/ms-playwright'
base-branch: 'main'
- name: Install Node Modules
uses: 'nrwl/nx-cloud-workflows/v4/workflow-steps/install-node-modules/main.yaml'
Expand All @@ -137,7 +132,6 @@ launch-templates:
key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|"browsers"'
paths: |
'../.cache/Cypress'
'../.cache/ms-playwright'
base-branch: 'main'
- name: Install Node Modules
uses: 'nrwl/nx-cloud-workflows/v4/workflow-steps/install-node-modules/main.yaml'
Expand All @@ -161,7 +155,6 @@ launch-templates:
key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|"browsers"'
paths: |
'../.cache/Cypress'
'../.cache/ms-playwright'
base-branch: 'main'
- name: Install Node Modules
uses: 'nrwl/nx-cloud-workflows/v4/workflow-steps/install-node-modules/main.yaml'
Expand Down

0 comments on commit 562fe45

Please sign in to comment.