Skip to content

Commit

Permalink
fix(install-node): use pre built binary nvm install (#69)
Browse files Browse the repository at this point in the history
* fix(install-node): only install node with prebuild binaries

Nx Agents arch should always have a pre-built binary, no need to waste
time accidently building from scratch and should fail fast instead.

* chore(repo): update lock file and build output

I just ran yarn after cloning and git push when ran build-all and got a
new output 🤷
  • Loading branch information
barbados-clemens authored and github-actions[bot] committed Oct 1, 2024
1 parent 0ef4cad commit 8953db2
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 634 deletions.
8 changes: 4 additions & 4 deletions workflow-steps/cache/output/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -380,9 +380,9 @@ var require_balanced_match = __commonJS({
}
});

// ../../node_modules/glob/node_modules/brace-expansion/index.js
// ../../node_modules/minimatch/node_modules/brace-expansion/index.js
var require_brace_expansion = __commonJS({
"../../node_modules/glob/node_modules/brace-expansion/index.js"(exports, module2) {
"../../node_modules/minimatch/node_modules/brace-expansion/index.js"(exports, module2) {
var concatMap = require_concat_map();
var balanced = require_balanced_match();
module2.exports = expandTop;
Expand Down Expand Up @@ -525,9 +525,9 @@ var require_brace_expansion = __commonJS({
}
});

// ../../node_modules/glob/node_modules/minimatch/minimatch.js
// ../../node_modules/minimatch/minimatch.js
var require_minimatch = __commonJS({
"../../node_modules/glob/node_modules/minimatch/minimatch.js"(exports, module2) {
"../../node_modules/minimatch/minimatch.js"(exports, module2) {
module2.exports = minimatch;
minimatch.Minimatch = Minimatch;
var path = function() {
Expand Down
8 changes: 4 additions & 4 deletions workflow-steps/cache/output/post.js
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,9 @@ var require_balanced_match = __commonJS({
}
});

// ../../node_modules/glob/node_modules/brace-expansion/index.js
// ../../node_modules/minimatch/node_modules/brace-expansion/index.js
var require_brace_expansion = __commonJS({
"../../node_modules/glob/node_modules/brace-expansion/index.js"(exports, module2) {
"../../node_modules/minimatch/node_modules/brace-expansion/index.js"(exports, module2) {
var concatMap = require_concat_map();
var balanced = require_balanced_match();
module2.exports = expandTop;
Expand Down Expand Up @@ -520,9 +520,9 @@ var require_brace_expansion = __commonJS({
}
});

// ../../node_modules/glob/node_modules/minimatch/minimatch.js
// ../../node_modules/minimatch/minimatch.js
var require_minimatch = __commonJS({
"../../node_modules/glob/node_modules/minimatch/minimatch.js"(exports, module2) {
"../../node_modules/minimatch/minimatch.js"(exports, module2) {
module2.exports = minimatch;
minimatch.Minimatch = Minimatch;
var path = function() {
Expand Down
4 changes: 2 additions & 2 deletions workflow-steps/install-node/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ if (platform === 'win32') {

function runNvmInstall(version) {
try {
// enable nvm and then run the install command
// enable nvm and then run the install command with -b to only install pre-build binaries
// nvm command isn't available since nx agents don't run the bash profile
const installNodeWithNvm = `. $NVM_DIR/nvm.sh && nvm install ${
const installNodeWithNvm = `. $NVM_DIR/nvm.sh && nvm install -b ${
version || ''
} --default`;
const reenableCorePack = `corepack enable`;
Expand Down
Loading

0 comments on commit 8953db2

Please sign in to comment.