Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch-template): remove playwright from browser cache #74

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

barbados-clemens
Copy link
Contributor

Playwright recommends not caching the binaries since restoring from the
cache usually takes longer than just downloading from the CDN.

Caching browser binaries is not recommended, since the amount of time
it takes to restore the cache is comparable to the time it takes to
download the binaries. Especially under Linux, operating system
dependencies need to be installed, which are not cacheable.

https://playwright.dev/docs/ci#caching-browsers

Playwright recommends not caching the binaries since restoring from the
cache usually takes longer than just downloading from the CDN.

> Caching browser binaries is not recommended, since the amount of time
it takes to restore the cache is comparable to the time it takes to
download the binaries. Especially under Linux, operating system
dependencies need to be installed, which are not cacheable.

https://playwright.dev/docs/ci#caching-browsers
Copy link

nx-cloud bot commented Nov 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c7c1a40. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@barbados-clemens barbados-clemens self-assigned this Nov 11, 2024
@barbados-clemens barbados-clemens enabled auto-merge (squash) November 11, 2024 17:23
@barbados-clemens barbados-clemens merged commit 7718cc6 into main Nov 12, 2024
2 checks passed
@barbados-clemens barbados-clemens deleted the fix/BAC-1253-do-not-cache-playwright branch November 12, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants