Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include path in cache hash calculation #83

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

rarmatei
Copy link
Contributor

@rarmatei rarmatei commented Jan 9, 2025

Currently, if the paths: get reconfigured for the caching step but they key stays the same, the caching step will keep pulling in the old folder until the key gets invalidated naturally.

This ensures someone can't get in that state, and it also includes the paths in the hash calculation.

Copy link

nx-cloud bot commented Jan 9, 2025

View your CI Pipeline Execution ↗ for commit b7b3ef8.

Command Status Duration Result
nx affected -t test ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-09 17:40:03 UTC

@rarmatei rarmatei force-pushed the include-path-in-cache-hash-calculation branch from abe33ef to b7b3ef8 Compare January 9, 2025 17:39
@rarmatei rarmatei merged commit 2ae4750 into main Jan 9, 2025
2 checks passed
@rarmatei rarmatei deleted the include-path-in-cache-hash-calculation branch January 9, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants