Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): add cjs, cts, mjs, and mts to the default extensions for the inference plugin #29534

Merged
merged 3 commits into from
Jan 29, 2025
Merged

fix(linter): add cjs, cts, mjs, and mts to the default extensions for the inference plugin #29534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcf298b
fix(linter): add cjs and mjs to the default extensions for the infere…
beaussan Jan 7, 2025
dc2fdb7
Merge branch 'master' into fix/add-cjs-and-esm-to-default-extentions
leosvelperez Jan 29, 2025
afd760b
fix(linter): include `cts` and `mts`
leosvelperez Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/eslint/src/generators/init/global-eslint-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ export const getGlobalFlatEslintConfiguration = (
files: [
'**/*.ts',
'**/*.tsx',
'**/*.cts',
'**/*.mts',
'**/*.js',
'**/*.jsx',
'**/*.cjs',
Expand Down
4 changes: 4 additions & 0 deletions packages/eslint/src/generators/lint-project/lint-project.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,8 @@ describe('@nx/eslint:lint-project', () => {
files: [
"**/*.ts",
"**/*.tsx",
"**/*.cts",
"**/*.mts",
"**/*.js",
"**/*.jsx",
"**/*.cjs",
Expand Down Expand Up @@ -396,6 +398,8 @@ describe('@nx/eslint:lint-project', () => {
files: [
"**/*.ts",
"**/*.tsx",
"**/*.cts",
"**/*.mts",
"**/*.js",
"**/*.jsx",
"**/*.cjs",
Expand Down
13 changes: 12 additions & 1 deletion packages/eslint/src/plugins/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,18 @@ export interface EslintPluginOptions {
extensions?: string[];
}

const DEFAULT_EXTENSIONS = ['ts', 'tsx', 'js', 'jsx', 'html', 'vue'];
const DEFAULT_EXTENSIONS = [
'ts',
'cts',
'mts',
'tsx',
'js',
'cjs',
'mjs',
'jsx',
'html',
'vue',
];
const PROJECT_CONFIG_FILENAMES = ['project.json', 'package.json'];
const ESLINT_CONFIG_GLOB_V1 = combineGlobPatterns(
ESLINT_CONFIG_FILENAMES.map((f) => `**/${f}`)
Expand Down