feat(node): update app generator for fastify to the next major v5 #29589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit f77d4cd.
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Jan 27, 2025
Coly010
changed the title
Coly010
added a commit
to Phillip9587/nx
that referenced
this pull request
Jan 27, 2025
…wl#29589) ## Current Behavior `npx create-nx-workspace`, when fastify is chosen, generates fastify 4 boilerplate ## Expected Behavior fastify bumped their major version, and many latest plugins require v5 (e.g. [cors](https://github.com/fastify/fastify-cors)) ## Related Issue(s) no - the combination of versions works on my setup - the combinations of versions is the latest at the moment --------- Co-authored-by: Colum Ferry <[email protected]>
Coly010
added a commit
to Phillip9587/nx
that referenced
this pull request
Jan 27, 2025
…wl#29589) `npx create-nx-workspace`, when fastify is chosen, generates fastify 4 boilerplate fastify bumped their major version, and many latest plugins require v5 (e.g. [cors](https://github.com/fastify/fastify-cors)) no - the combination of versions works on my setup - the combinations of versions is the latest at the moment --------- Co-authored-by: Colum Ferry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
npx create-nx-workspace, when fastify is chosen, generates fastify 4 boilerplateExpected Behavior
fastify bumped their major version, and many latest plugins require v5 (e.g. cors)
Related Issue(s)
no