Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Initial version #3

wants to merge 6 commits into from

Conversation

mike-petrov
Copy link

closes #1

Signed-off-by: Mikhail Petrov [email protected]

@mike-petrov mike-petrov self-assigned this Jan 16, 2025
@mike-petrov
Copy link
Author

Screenshot 2025-01-16 at 20 39 26 Screenshot 2025-01-16 at 20 39 49 Screenshot 2025-01-16 at 20 41 31

@mike-petrov
Copy link
Author

mike-petrov commented Jan 16, 2025

@roman-khimov first working version above, now I'm doing streaming file downloads in the background with no memory load.

Signed-off-by: Mikhail Petrov <[email protected]>
Follows send.fs.neo.org mostly.

Signed-off-by: Mikhail Petrov <[email protected]>
Follows send.fs.neo.org mostly.

Signed-off-by: Mikhail Petrov <[email protected]>
Signed-off-by: Mikhail Petrov <[email protected]>
Signed-off-by: Mikhail Petrov <[email protected]>
@mike-petrov mike-petrov force-pushed the feature/1-initial_version branch 2 times, most recently from 44cafcd to 422263c Compare January 23, 2025 16:22
@mike-petrov
Copy link
Author

image image image

@mike-petrov mike-petrov force-pushed the feature/1-initial_version branch from ad9a26d to e5b9728 Compare January 23, 2025 16:41
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Min/max do not read well, we need something like "the latest available block is XXX" dependent on the network.

Downloading the full set should be like opening up the page and hitting one button, that is 0 and the latest should be pre-filled (on network switch)

Browser limitations should be clearly explained, IIRC Firefox can't do this because it doesn't support appropriate API.

Some "About" can be useful as well explaining how it works similar to how send.fs.neo.org has it.

## [Unreleased]


## [0.1.0] - 2025-01-15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not there yet.


try {
const fileHandle = await window.showSaveFilePicker({
suggestedName: `snapshot_${nets[formData.network].title}_${formData.spanStart}-${formData.spanEnd}.acc`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow sync.ngd.network in naming, it is important for C# node in fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial version
2 participants