rpcsrv: enforce default config values on server creation if malformed value specified #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need default values in |
AnnaShaleva
force-pushed
the
default-iter-items-conut
branch
2 times, most recently
from
599bb09
to
db1a120
Compare
roman-khimov
approved these changes
Aug 29, 2023
Do not use RPC configuration constructor for this, some external services may skip this part. Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
Do not use RPC configuration constructor for this, some external services may skip this part. Signed-off-by: Anna Shaleva <[email protected]>
Do not use RPC configuration constructor for this, some external services may skip this part. Signed-off-by: Anna Shaleva <[email protected]>
Do not use RPC configuration constructor for this, some external services may skip this part. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
default-iter-items-conut
branch
from
db1a120
to
b89078c
Compare
|
Tests pass now. |
Codecov Report
@@ Coverage Diff @@
## master #3107 +/- ##
=======================================
Coverage 84.81% 84.81%
=======================================
Files 329 329
Lines 44222 44232 +10
=======================================
+ Hits 37507 37517 +10
Misses 5206 5206
Partials 1509 1509
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #3106. This PR makes the life of NeoFS IR supernode better.