notary: avoid changing pooled fallback transaction witnesses #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3108 +/- ##
=======================================
Coverage 84.81% 84.81%
=======================================
Files 329 329
Lines 44222 44239 +17
=======================================
+ Hits 37507 37522 +15
- Misses 5206 5208 +2
Partials 1509 1509
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
approved these changes
Aug 29, 2023
Forbid Notary service to change the fallback's witnesses in any way. Fix the problem described in review comment: #3098 (comment). Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
create-fallback-copy
branch
from
4aab2fa to
c63289a
Compare
roman-khimov
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbid Notary service to change the fallback's witnesses in any way. Fix the problem described in review comment: #3098 (comment).
I won't say it's a bug, because no one has used the notary pool before
getrawnotarytransactionandgetrawnotarypoolappearance.