Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: reuse org-wide DCO workflow #3109

Merged
merged 1 commit into from
Aug 29, 2023
Merged

workflows: reuse org-wide DCO workflow #3109

merged 1 commit into from
Aug 29, 2023

Conversation

roman-khimov
Copy link
Member

@mike-petrov, it can look like this in other repos. We just drop a local copy and go with an org-wide workflow.

AnnaShaleva
AnnaShaleva approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the new job name looks less nice than the previous one: DCO check / commits_check_job / Commits Check (pull_request)

@roman-khimov roman-khimov merged commit 2d4e1b5 into master Aug 29, 2023
12 of 16 checks passed
@roman-khimov roman-khimov deleted the reuse-org-dco-workflow branch August 29, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roman-khimov @AnnaShaleva